[DisplayedElements] properly handle line shape #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great ! can you rebase your branch please ? then we can merge it |
techfreaque
force-pushed
the
fix_displayed_element_line_shape
branch
3 times, most recently
from
05b771c
to
0b171d4
Compare
done |
| @@ -266,6 +270,7 @@ async def _get_cached_values_to_display(self, cached_value_metadata, x_shift, st | |||
| cache_displayed_value = plotted_displayed_value = cached_value_metadata["cache_value"] | |||
| kind = cached_value_metadata["kind"] | |||
| mode = cached_value_metadata["mode"] | |||
| line_shape = cached_value_metadata["line_shape"] | |||
There was a problem hiding this comment.
this requires the plot keyword to set "line_shape"
There was a problem hiding this comment.
thats already added
techfreaque
force-pushed
the
fix_displayed_element_line_shape
branch
from
0b171d4
to
11de29e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a little clean up and line shape will now work properly